it is probably a good idea to have the key expire. I imagine there is a lot of keys out there where people did generate a key and then forgot what their passphrase was. 

Also when you generate the key make a revocation cert. If you lose the key or it gets compromised you can then revoke the key. 